Skip to content

[Jetsurvey] Improve permissions UX #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2021
Merged

[Jetsurvey] Improve permissions UX #577

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dc36ef
[Jetsurvey] Improve permissions UX
Jun 18, 2021
aa265d4
[Permissions] Improve logic
Jun 18, 2021
1021b4d
[Permissions] Spotless fix
Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 20 additions & 33 deletions Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/survey/SurveyQuestions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
Expand Down Expand Up @@ -96,9 +95,6 @@ fun Question(
} else {
val permissionsContentModifier = modifier.padding(horizontal = 20.dp)

// When true, the permissions request must be presented to the user.
var launchPermissionsRequest by rememberSaveable { mutableStateOf(false) }

val multiplePermissionsState =
rememberMultiplePermissionsState(question.permissionsRequired)

Expand All @@ -107,28 +103,27 @@ fun Question(
multiplePermissionsState.allPermissionsGranted -> {
QuestionContent(question, answer, onAnswer, onAction, modifier)
}
// The user denied some permissions but a rationale should be shown
multiplePermissionsState.shouldShowRationale -> {
if (!shouldAskPermissions) {
PermissionsDenied(
question.questionText,
openSettings,
permissionsContentModifier
)
} else {
PermissionsRationale(
question,
multiplePermissionsState,
onDoNotAskForPermissions,
permissionsContentModifier
)
// If user denied some permissions but a rationale should be shown or the user
// is going to be presented with the permission for the first time. Let's explain
// why we need the permission
multiplePermissionsState.shouldShowRationale ||
!multiplePermissionsState.permissionRequested ->
{
if (!shouldAskPermissions) {
PermissionsDenied(
question.questionText,
openSettings,
permissionsContentModifier
)
} else {
PermissionsRationale(
question,
multiplePermissionsState,
onDoNotAskForPermissions,
permissionsContentModifier
)
}
}
}
// The permissions are not granted, the rationale shouldn't be shown to the user,
// and the permissions haven't been requested previously. Request permission!
!multiplePermissionsState.permissionRequested -> {
launchPermissionsRequest = true
}
// If the criteria above hasn't been met, the user denied some permission.
else -> {
PermissionsDenied(question.questionText, openSettings, permissionsContentModifier)
Expand All @@ -139,14 +134,6 @@ fun Question(
}
}

// Trigger a side-effect to request the permissions if they need to be presented to the user
if (launchPermissionsRequest) {
LaunchedEffect(multiplePermissionsState) {
multiplePermissionsState.launchMultiplePermissionRequest()
launchPermissionsRequest = false
}
}

// If permissions are denied, inform the caller that can move to the next question
if (!shouldAskPermissions) {
LaunchedEffect(true) {
Expand Down