Bump to dev08 snapshot build. #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes:
* Refactored modifiers to use fluent style throughout
* Switched to new use Icon and Image composables
* Switch to using IconButton where appropriate
* Updated Scaffolding to use IconButton for navigationIcon
* Removed vector helpers from sample that are now included in the library
* Update typography of code paraghraphs to expand, and avoid setting background
on text in code blocks as alpha is not respected – use the background of the Box
* Replaced all Container with Box
* General code cleanup to remove nesting that can be replaced with modifiers
* Moved Modifiers to *first default argument* to follow style
* Aligned bullets with baseline of text
* Sized bullets based on font scaling
* Removed many named arguments that were not required for readibility
nickbutcher
reviewed
Mar 31, 2020
nickbutcher
reviewed
Mar 31, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/article/ArticleScreen.kt
Show resolved
Hide resolved
nickbutcher
reviewed
Mar 31, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/article/ArticleScreen.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Mar 31, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/article/ArticleScreen.kt
Show resolved
Hide resolved
nickbutcher
reviewed
Mar 31, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/article/PostContent.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Mar 31, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/article/PostContent.kt
Outdated
Show resolved
Hide resolved
manuelvicnt
reviewed
Mar 31, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/article/ArticleScreen.kt
Show resolved
Hide resolved
JetNews/app/src/main/java/com/example/jetnews/ui/article/PostContent.kt
Outdated
Show resolved
Hide resolved
JetNews/app/src/main/java/com/example/jetnews/ui/article/PostContent.kt
Outdated
Show resolved
Hide resolved
JetNews/app/src/main/java/com/example/jetnews/ui/article/PostContent.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Mar 31, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/article/PostContent.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Mar 31, 2020
nickbutcher
reviewed
Mar 31, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/article/PostContent.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Mar 31, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/article/PostContent.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Mar 31, 2020
nickbutcher
reviewed
Mar 31, 2020
nickbutcher
reviewed
Mar 31, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/interests/SelectTopicButton.kt
Outdated
Show resolved
Hide resolved
* Swapped Image for Icon in several places * Prefer srcIn * Added note for bugfix w/ link to bug
|
Updated based on PR notes. PTAL again @manuelvicnt and @nickbutcher |
nickbutcher
reviewed
Apr 1, 2020
nickbutcher
reviewed
Apr 1, 2020
nickbutcher
reviewed
Apr 1, 2020
nickbutcher
reviewed
Apr 1, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/article/ArticleScreen.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Apr 1, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Apr 1, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/home/PostCardTop.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Apr 1, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/home/PostCardYourNetwork.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Apr 1, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/home/PostCards.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Apr 1, 2020
JetNews/app/src/main/java/com/example/jetnews/ui/home/PostCards.kt
Outdated
Show resolved
Hide resolved
* Switch some Icons back to Image that were not really icons * Use ColorFilter.tint to semantically tint vectors * Formatting
|
Thanks for review! Updated everything except |
|
@nickbutcher can you check out the icon coloring on the bottom bar? I'm not sure which call to make there, it might be worth checking the design. Here's a screenshot showing both (heart is an Icon and bookmark is an Image)
|
|
Checked Figma and the icons on the |
* Revert to Modifier.None for default arugments which is the style in dev08
* Use Icon for all Icons, which matches design.
|
Thanks! All suggested changes in, hitting the button! |
nickbutcher
pushed a commit
that referenced
this pull request
Apr 3, 2020
* Bump to dev08.
Changes:
* Refactored modifiers to use fluent style throughout
* Switched to new use Icon and Image composables
* Switch to using IconButton where appropriate
* Updated Scaffolding to use IconButton for navigationIcon
* Removed vector helpers from sample that are now included in the library
* Update typography of code paraghraphs to expand, and avoid setting background
on text in code blocks as alpha is not respected – use the background of the Box
* Replaced all Container with Box
* General code cleanup to remove nesting that can be replaced with modifiers
* Moved Modifiers to *first default argument* to follow style
* Aligned bullets with baseline of text
* Sized bullets based on font scaling
* Removed many named arguments that were not required for readibility
* Added note for bugfix related to font coloring requiring contentColor w/ link to b/143626708
* Use ColorFilter.tint to semantically tint vectors
* Continue using Modifier.None for default arugments which is the style in dev08, this is likely to be replaced with `Modifier` in dev09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
on text in code blocks as alpha is not respected – use the background of the Box