Skip to content
This repository was archived by the owner on Oct 16, 2018. It is now read-only.

Conversation

rusmonster
Copy link

@rusmonster rusmonster commented Nov 23, 2017

While the problem of marking result expressions mentionered here still not solved in kotlin, it is good idea to fix it on the code style level due to avoid fights between developers :)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@rusmonster
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@JakeWharton
Copy link
Contributor

From what I remember this is contrary to the advice of the JetBrains style guide for Kotlin. We'll have to make sure that's not the case, and even then i'm wary of such a hard rule for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants