Skip to content

Conversation

trambui09
Copy link
Contributor

Adding setCustomAnimations with PB support into Platform Samples

@trambui09 trambui09 requested review from ashnohe and yaraki April 1, 2024 21:23
@@ -0,0 +1,46 @@
/*
* Copyright 2023 The Android Open Source Project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2024

~ limitations under the License.
-->

<!--<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused code

@trambui09 trambui09 requested a review from yaraki April 8, 2024 21:59
Copy link
Contributor

@ashnohe ashnohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor requested changes

app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />

<TextView
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making this a button and have the user click the button instead of the box. Then, in the second fragment, make the UI a bit different (change the box size and color for example) so the user can see the transition more apparently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Decided the change to a button for Fragment A. I tried to get the button color to be the same as the box color, but somehow it's still turning out to be purple

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For the button background, try adding app:backgroundTint="@null" to the Button.

<!-- app:layout_constraintStart_toStartOf="parent"-->
<!-- app:layout_constraintTop_toTopOf="parent" />-->

<View
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making this box different, change the color and the size.

TRANSITION,
MATERIAL_SHARED_AXIS
MATERIAL_SHARED_AXIS,
SET_CUSTOM_ANIMATIONS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: to make better diff in the future

Suggested change
SET_CUSTOM_ANIMATIONS
SET_CUSTOM_ANIMATIONS,

@trambui09 trambui09 requested a review from ashnohe April 30, 2024 23:45
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />

<TextView
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For the button background, try adding app:backgroundTint="@null" to the Button.

@trambui09 trambui09 merged commit 3be03ee into android:main May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants