Updated sample UI to match the catalog style and added dark theme support #284
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @romanofranz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the sample UI for the window manager demos to match the catalog style and adds dark theme support. The primary changes involve refactoring the DemoItem class to use 'title' instead of 'buttonTitle', updating the DemoVH class to use a MaterialCardView and display the title and description, modifying the layout file view_holder_demo_item.xml to use MaterialCardView and display the title and description, updating the color palette in colors.xml, and updating the base theme to Theme.MaterialComponents.DayNight in styles.xml.
Highlights
- UI Update: The UI has been updated to use MaterialCardView for a more modern look and feel.
- Dark Theme Support: Dark theme support has been added by switching to
Theme.MaterialComponents.DayNight. - Code Refactoring: The
DemoItemclass now uses 'title' instead of 'buttonTitle' for clarity. - Click Handling: Click handling has been moved from the button to the entire container for a better user experience.
Changelog
Click here to see the changelog
- samples/user-interface/windowmanager/src/main/java/com/example/platform/ui/windowmanager/demos/DemoItem.kt
- Renamed
buttonTitletotitlein theDemoItemclass.
- Renamed
- samples/user-interface/windowmanager/src/main/java/com/example/platform/ui/windowmanager/demos/DemoVH.kt
- Replaced the
launchButtonwith acontainerview to handle clicks. - Replaced
launchButtonwithtitleTextView. - Click listener is now set on the container instead of the button.
- Replaced the
- samples/user-interface/windowmanager/src/main/java/com/example/platform/ui/windowmanager/demos/WindowDemosActivity.kt
- Updated the
DemoItemconstructor to usetitleinstead ofbuttonTitle.
- Updated the
- samples/user-interface/windowmanager/src/main/res/layout/view_holder_demo_item.xml
- Replaced LinearLayout with MaterialCardView.
- Replaced Button with TextView for the title.
- Added TextView for the description.
- samples/user-interface/windowmanager/src/main/res/values/colors.xml
- Updated
colorPrimaryandcolorPrimaryDarkcolors.
- Updated
- samples/user-interface/windowmanager/src/main/res/values/styles.xml
- Updated the parent theme of
AppThemetoTheme.MaterialComponents.DayNight. - Updated the parent theme of
FoldableMediaPlayertoTheme.MaterialComponents.DayNight.NoActionBar. - Removed
colorAccentfromAppTheme.
- Updated the parent theme of
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
From AppCompat's light,
To Material's DayNight,
A theme's swift flight,
Darkness takes its height.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request updates the sample UI to match the catalog style and adds dark theme support. The changes include renaming a variable, updating the layout file to use MaterialCardView, and updating the colors and styles to support dark theme. Overall, the changes seem reasonable and improve the look and feel of the application.
Summary of Findings
- Accessibility of Demo Items: The original implementation used a Button for launching demos, which is inherently accessible. The updated implementation uses a MaterialCardView with a LinearLayout and TextViews. Ensure that the new implementation maintains the same level of accessibility, especially for users with disabilities.
Merge Readiness
The pull request seems to be in good shape. However, it's important to ensure that the changes maintain the same level of accessibility as the original implementation. I am unable to directly approve the pull request, and other reviewers should review and approve this code before merging.
|
/gemini summarize |
Summary of ChangesThis pull request updates the sample UI for the windowmanager to match the catalog style and adds dark theme support. The changes include modifying the Highlights
Changelog
Activity
|
No description provided.