-
Notifications
You must be signed in to change notification settings - Fork 414
Add category to quick tiles sample #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: I29def8cf1523d4cd063e1095484cff3ca9efa088
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @alabiaga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the quick tiles sample application to incorporate the new category feature introduced in Android 16 QPR2 Beta 1. The changes involve updating the project's target SDK and adding a specific metadata entry in the Android Manifest to assign a 'Utility' category to the sample quick tile, demonstrating how to organize quick tiles within the system's Quick Settings edit interface.
Highlights
- Target SDK Update: The
targetSdk
inbuild.gradle.kts
was updated from 35 to 36, aligning the sample with newer Android API levels. - Quick Tile Categorization: A new
<meta-data>
tagandroid.service.quicksettings.TILE_CATEGORY
with valueandroid.service.quicksettings.CATEGORY_UTILITIES
was added toAndroidManifest.xml
to categorize the sample quick tile as a utility, reflecting the new feature in Android 16 QPR2 Beta 1.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Quick Settings tile sample to include a category, a new feature introduced in Android 16. The changes correctly update the targetSdk
to 36 and add the necessary TILE_CATEGORY
metadata in the AndroidManifest.xml
. My feedback focuses on improving the code style and comment clarity for this new addition to ensure consistency and readability.
<!-- | ||
Categorize this tile as a Utility so that it's organized in that category in | ||
Quick Settings edit. Available in Android 16.1. | ||
--> | ||
<meta-data android:name="android.service.quicksettings.TILE_CATEGORY" | ||
android:value="android.service.quicksettings.CATEGORY_UTILITIES" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the rest of the file and for better readability, it's recommended to format the new meta-data
tag and its preceding comment. This includes:
- Fixing the indentation within the XML comment.
- Clarifying the Android version in the comment to be more specific (e.g., using the API level).
- Formatting the
meta-data
tag to have each attribute on a new line, which matches the style of othermeta-data
tags in this file.
<!--
Categorize this tile as a Utility so that it's organized in that category in
Quick Settings edit. Available in Android 16 (API level 36).
-->
<meta-data
android:name="android.service.quicksettings.TILE_CATEGORY"
android:value="android.service.quicksettings.CATEGORY_UTILITIES" />
Change-Id: Iab0b01de7ce02727869d479de64a17c6737715df
Android 16 QPR2 Beta 1 introduces categories for quick tiles. Updating sample to reflect change.