-
Notifications
You must be signed in to change notification settings - Fork 414
Fix merge manifest issue causing platform samples not to build #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: I28fb39fcfc0176739704ae38a95214f16743937a
Summary of ChangesHello @alabiaga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical build failure within the platform samples by strategically managing Android manifest merge conflicts. It ensures that modules requiring a higher minimum SDK version can coexist with the main application without forcing a global Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully resolves a manifest merger issue by using tools:overrideLibrary
to handle conflicting minSdk
versions from dependencies. Additionally, it updates the description for the Storage API surface to warn users about the new minimum SDK requirement. The changes are effective, but I have a couple of suggestions to improve code style and readability in the AndroidManifest.xml
and ApiSurface.kt
files.
Change-Id: I2fc9d12ee60121cbce3a5ff31d7440c250511e84
Change-Id: Ib78d89b29a4b36ac0bf86fdf9df5de18f76a70bc
Change-Id: I3b76c82542a3ceec0455f48a6bb5457b770b08fd
Change-Id: Ia0aa975a0eee0c9f8201cdb18694621dd831df48
update comment to reflect that the min sdk override is specific to the modules defined rather than mentioning it specifically in the comment
Fixes #366