-
Notifications
You must be signed in to change notification settings - Fork 268
Migrate snippets from Material 3 #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a minor comment about a comment 😆
|
||
private object Material3Snippets { | ||
// [START android_compose_material3_experimental_annotation] | ||
// import androidx.compose.material3.ExperimentalMaterial3Api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Might this be confused for commenting this import out? Perhaps phrasing it like "Make sure to import..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Chris - we've done it like this in a few other places so i think its okay..
No description provided.