Skip to content

Conversation

riggaroo
Copy link
Collaborator

No description provided.

Copy link

snippet-bot bot commented Nov 21, 2023

Here is the summary of changes.

You are about to add 26 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a minor comment about a comment 😆


private object Material3Snippets {
// [START android_compose_material3_experimental_annotation]
// import androidx.compose.material3.ExperimentalMaterial3Api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Might this be confused for commenting this import out? Perhaps phrasing it like "Make sure to import..."?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris - we've done it like this in a few other places so i think its okay..

@riggaroo riggaroo merged commit c2593d5 into main Nov 21, 2023
@riggaroo riggaroo deleted the riggaroo/theming-snippets-migration branch November 21, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants