Skip to content

Add WebView snippets #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Add WebView snippets #503

merged 1 commit into from
Apr 23, 2025

Conversation

cy245
Copy link
Contributor

@cy245 cy245 commented Apr 22, 2025

Added snippets for https://developer.android.com/identity/sign-in/credential-manager-webview. Some slight modifications:

  • Combined first and second snippets since the former is a subset of the latter and it's awkward to break up a class declaration into 2 parts
  • Updated "Initialize the WebView" section to include function header to make it clearer
  • Combined last 2 snippets since they're part of the same function
  • "INJECTED_VAL" is a very long string that is from the original app. While not part of a snippet, I've kept as-is for future reference

@cy245 cy245 requested review from sanbeiji and neelanshsahai April 22, 2025 22:36
Copy link

snippet-bot bot commented Apr 22, 2025

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@neelanshsahai
Copy link
Contributor

neelanshsahai commented Apr 23, 2025

LGTM
Nit: Spotless defaults to 4 spaces per tab indentation. Some files in the project have 2 space indent, and some have 4 space indent.
After adding spotless, we can run a quick build post merging this

@cy245
Copy link
Contributor Author

cy245 commented Apr 23, 2025

LGTM Nit: Spotless defaults to 4 spaces per tab indentation. Some files in the project have 2 space indent, and some have 4 space indent. After adding spotless, we can run a quick build post merging this

Thanks Neelansh. Let's run a quick followup CL to fix the formatting w/Spotless since it affects other files too.

@cy245 cy245 merged commit 6f36723 into main Apr 23, 2025
5 checks passed
@cy245 cy245 deleted the identity_webview_snippets branch April 23, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants