Default values in Scala case class should be added as default in json-schema #20 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 11, 2019 22:29
bjornbak
reviewed
Oct 14, 2019
project/build.properties
Outdated
| @@ -1 +1 @@ | |||
| sbt.version = 1.2.7 No newline at end of file | |||
| sbt.version = 1.3.0 No newline at end of file | |||
There was a problem hiding this comment.
sbt 1.3.0 is broken. You should use 1.3.2
There was a problem hiding this comment.
just curious what's wrong with 1.3.0?
and. there is already a 1.3.3 one.. looks fine, right?
There was a problem hiding this comment.
https://discuss.lightbend.com/t/announce-sbt-1-3-2/5111
I saw the 1.3.3 announcement ½ hour after I created the review :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.