-
Notifications
You must be signed in to change notification settings - Fork 7
Make diffing stack safe #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@andyglow is there any chance you could review this and potentially release a new version if/when it's merged? Let me know if there's any more info or clarification I can provide |
No, no questions.. |
Sure thing @andyglow, just pushed another commit to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
hey @mrdziuban |
Thank you! |
Fixes #14
cats.Eval
which guarantees stack safety when usingmap
/flatMap
XmlDiffComputer
to wrap their results inEval
StackOverflowError