Skip to content

Conversation

hosamaly
Copy link
Contributor

@hosamaly hosamaly commented Mar 7, 2018

This PR fixes the build in Travis CI. Passing Build

In addition, it includes the following changes:

  • Add LGPL to the list of licenses in sbt (already added to the project in COPYING.LESSER)
  • Upgrade scala versions, sbt, and dependencies, except for the scala-xml dependency lest it forces an upgrade on library users.

hosamaly added 3 commits March 7, 2018 12:29
Except for the scala-xml dependency, lest it forces an upgrade on library users.
* Update the Scala versions
* Force the Scala version during tests
* Improve caching as per sbt's docs
@coveralls
Copy link

coveralls commented Mar 7, 2018

Coverage Status

Coverage remained the same at 82.119% when pulling b7f46c3 on hosamaly:master into 6344b6d on andyglow:master.

@andyglow
Copy link
Owner

andyglow commented Mar 7, 2018

that's cool!
thanks a lot
accepting

@andyglow andyglow merged commit c8ca045 into andyglow:master Mar 7, 2018
@hosamaly
Copy link
Contributor Author

hosamaly commented Mar 7, 2018

That's great, @andyglow. Thank you!

Would you be able to release a new version and publish it for both versions of Scala?

@hosamaly
Copy link
Contributor Author

hosamaly commented Mar 8, 2018

That's great. Thanks, Andy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants