Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update packages to newer versions #1

Merged
merged 1 commit into from
Dec 1, 2021
Merged

update packages to newer versions #1

merged 1 commit into from
Dec 1, 2021

Conversation

Cmdv
Copy link
Contributor

@Cmdv Cmdv commented Nov 15, 2021

Hi I was just working my way through this blog post and it was failing as craco & react-scripts have both updated and things just wouldn't compile.

I've tested this locally and it all seems to be aok 👍

@andys8
Copy link
Owner

andys8 commented Nov 15, 2021

Cool. Thanks. Could you tell me what "things just wouldn't compile" means in detail? Could you provide the error message?

There is also a companion repository using this loader, which I would also expect needs to be updated.

https://github.com/andys8/create-react-app-purescript

@andys8
Copy link
Owner

andys8 commented Nov 15, 2021

In addition the blog post contains versions and should probably also be updated

https://github.com/thomashoneyman/writing/blob/main/articles/replace-react-components-with-purescript.md

@Cmdv
Copy link
Contributor Author

Cmdv commented Nov 15, 2021

@andys8 well it's because of these line:

npm install --save @craco/craco
npm install --save-dev craco-purescript-loader

https://github.com/thomashoneyman/writing/blob/main/articles/replace-react-components-with-purescript.md?plain=1#L178-L180

so the first line installs the latest version 6.4.0 of craco locally to the project and this library is a little behind at 5.6.4 which gives you:

hile resolving: my-app@0.1.0
npm ERR! Found: @craco/craco@6.4.0
npm ERR! node_modules/@craco/craco
npm ERR!   @craco/craco@"^6.4.0" from the root project

could not resolve dependency:
npm ERR! peer @craco/craco@"^5.6.4" from craco-purescript-loader@1.0.1

one can get around it by using the npm flag --force but that always feels a little off to me 😱

oooh hadn't seen the repo you created too, that should come really handy. I'm attempting to convince and convert an existing React app into a React-Purescript one in an incremental manner 😄

@andys8
Copy link
Owner

andys8 commented Dec 1, 2021

Will update dependencies now :) Thank you

@Cmdv
Copy link
Contributor Author

Cmdv commented Dec 1, 2021

Thanks @andys8 much appreciated 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants