Skip to content

Conversation

YannickLauzier
Copy link

@YannickLauzier YannickLauzier commented Sep 29, 2017

Here a little fix for Laravel 5.5. :-)

The fire Method
Any fire methods present on your Artisan commands should be renamed to handle.
https://laravel.com/docs/5.5/upgrade

@hmazter reported the issue.
#40

Thanks ! :-)

@simonlague
Copy link

Thanks !

@andywer
Copy link
Owner

andywer commented Sep 30, 2017

Thx for the PR, @YannickLauzier!

The Laravel core devs are really not into semver, are they? 😅

Only concern here: This change will break compatibility with previous Laravel 5.x versions. Maybe we should keep the fire method and just add a handle method, just adding a comment why there are both.

Otherwise we need to create another branch for the 5.5 code.

@fjoho
Copy link
Contributor

fjoho commented Oct 12, 2017

Decided what to do with this? Maybe having both fire and handle is a good idea for supporting Laravel 5.x

@hmazter
Copy link

hmazter commented Oct 12, 2017

Having both is how I have solved one of my packages.
https://github.com/hmazter/laravel-schedule-list/blob/master/src/Console/ListScheduler.php#L82-L88

@andywer
Copy link
Owner

andywer commented Nov 1, 2017

Fixed by #42. Thanks, @fjoho! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants