Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure IP addresses on storage server interface #223

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

nachtjasmin
Copy link
Contributor

Description

As part of SESUP-94, it happened that the permissions were missing to query the IP addresses. This ended up in invalid mounts which weren't even removable properly, cause the driver assumed that everything as working.

To prevent invalid mounts again, this check now verifies whether we have an IP address set and if not, it returns an error.

Checklist

  • added release notes to Unreleased section in CHANGELOG.md, if user facing change

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request

…interface

As part of SESUP-94, it happened that the permissions were missing to
query the IP addresses. This ended up in invalid mounts which weren't
even removable properly, cause the driver assumed that everything as
working.

To prevent invalid mounts again, this check now verifies whether we have
an IP address set and if not, it returns an error.
@nachtjasmin nachtjasmin force-pushed the joster/change-vmwtvkrwxykw branch from 08a18ea to 2901776 Compare September 3, 2024 14:01
Copy link
Contributor

@89Q12 89Q12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed hacky but works and thats what counts :3
Thank you for the time you invested!

@nachtjasmin nachtjasmin merged commit 510f1f9 into main Sep 6, 2024
9 checks passed
@nachtjasmin nachtjasmin deleted the joster/change-vmwtvkrwxykw branch September 6, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants