Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make contributing file #198

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Make contributing file #198

merged 3 commits into from
Aug 25, 2020

Conversation

ngreenwald
Copy link
Member

Adds documentation for how to contribute to our project. Closes #195

Copy link
Contributor

@ackagel ackagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just two comments relating to a technical workflow description.

  • Do we want to give any specific commands or link to tutorials to using git?
  • Kind of on that note, should we mention that one should realistically only work on one major branch/feature at a time?

@ngreenwald
Copy link
Member Author

Good point, I'll add in a git/github link.

I think the one issue at a time thing is more for us than for everyone else.

Copy link
Contributor

@alex-l-kong alex-l-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@ackagel ackagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go

@ngreenwald ngreenwald merged commit 7568170 into master Aug 25, 2020
@ngreenwald ngreenwald deleted the contributing_guidelines branch August 25, 2020 05:31
alex-l-kong pushed a commit that referenced this pull request Jan 14, 2021
* Make contributing file

* Create pull_request_template.md

* Add links to git and github explainers
y2kbugger pushed a commit that referenced this pull request Jul 29, 2021
* Make contributing file

* Create pull_request_template.md

* Add links to git and github explainers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CONTRIBUTING.md and pull_request_template to repo
3 participants