Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to change scale factor for cell segmentation #434

Merged
merged 3 commits into from
Jul 27, 2021

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Closes #423. Segment_Image_Data.ipynb does not make it obvious that the image scaling factor can be adjusted. We add an option to allow the user to easily override the default value of 1.0.

How did you implement your changes

Add a cell before the call to create_deepcell_output to allow the user to set the scale argument.

@alex-l-kong alex-l-kong self-assigned this Jul 26, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added some additional clarification

templates/Segment_Image_Data.ipynb Outdated Show resolved Hide resolved
ngreenwald and others added 2 commits July 27, 2021 09:04
Co-authored-by: Noah F. Greenwald <noahfgreenwald@gmail.com>
@ngreenwald ngreenwald merged commit 8b929c1 into master Jul 27, 2021
@ngreenwald ngreenwald deleted the rescale_doc branch July 27, 2021 16:59
y2kbugger pushed a commit that referenced this pull request Jul 29, 2021
* Add cell in Segment_Image_Data to change scale factor for Mesmer segmentation

* Update description of rescale_factor

Co-authored-by: Noah F. Greenwald <noahfgreenwald@gmail.com>

Co-authored-by: Noah F. Greenwald <noahfgreenwald@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rescale information to notebook
2 participants