-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GoogleDrivePath Dead Code #528
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…bjects as file paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a ton of stylistic changes in the PR. I'm not necessarily opposed to them, but we should come to a general consensus first about what patterns we're trying to encourage. Based on looking at the first file, I'm not quite grasping what the theme is for the changes being made.
This also makes it hard to identify which code changes are related to purpose of the PR
Oh, that wasn't intended, I think my formatter may have done it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. One more cleanup, there should be a folder called .toks which can be removed. It held api relevant info like the encrypted google cloud api token.
@ackagel Should I also remove mentions of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Will you confirm that there's no issues with the dockerfile by changing dockerhub from on tag
to on commit
and then pulling the latest image? You can check out @alex-l-kong's last commit on the pixel clustering PR to see, or ask him for help at standup today
@ngreenwald The docker builds successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks good
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #512. Removes all references to
GoogleDrivePath
.How did you implement your changes
All use cases of the Google Drive API in ark-analysis.
Google Python Packages in the
requirements.txt
and insetup.py
.data_utils.py
GoogleDrivePath
,drive_write_out
,path_join
deepcell_service_utils.py
GoogleDrivePath
,drive_write_out
,path_join
,DriveOpen
google_drive_utils_test.py
google_drive_utils.py
io_utils
load_utils.py
segmentation_utils.py
drive_write_out
andpath_join
conf.py
index.rst
google_drive_usage.md
Segment_Image_Data.ipynb
deepcell_service_utils.py
.Remove Google API tokens
Successfully building the Docker Image
Remaining issues
None ATM.