Skip to content

ignoreUnusedDeps: primeng dialog mask element not cleared from the DOM when closed #934

@alaindeurveilher

Description

@alaindeurveilher

With what library do you have an issue?

native-federation

Reproduction of the bug/regression with instructions

When using components with overlays/masks from primeNG, the overlayed elements and masks are not cleared/removed/hidden when attempting to close those elements.

To reproduce the issue, clone the repository: https://github.com/alaindeurveilher/overlay-components.git

The main component contains a button which opens a dialog

There are 2 branches

  • "master" is the app with Angular/PrimeNG without Native Federation.
    • on master, the dialog opens correctly, and when closing the dialog, everything is working as expected and the backdrop is cleared
  • "with-native-federation" is the same app configured as a shell with native federation
    • on with-native-federation, when closing the dialog, the backdrop mask div element is not cleared from the dom

Image

Expected behavior

Example for the Dialog: All the DOM must be cleaned upon closing the dialog, the mask element should be cleared.

Versions of Native/Module Federation, Angular, Node, Browser, and operating system

Native Federation: 20.1.6
Angular: 20.2.3
PrimeNG: 20.0.1

The application is zoneless. See the default federation.config.js on the repo for more information.

Other information

It's the same behaviour for all kinds of component that use a sort of overlay or a mask: popover, etc.

I would be willing to submit a PR to fix this issue

  • Yes
  • No

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions