-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings displayed by webpack when using source-map-loader #64
Comments
@TobiasKrogh thanks for letting us know. Wondering if including the src with the npm package might be useful though for development/debugging purposes. |
@e-schultz I basically just followed the default configuration for the source-map-loader. I am fairly new to webpack, angular2 and ng2-redux. Just wondered about the warnings. However excluding ng2-redux from this loader works fine from my point of view. Just wanted to let you know in case this has some other implications or others stumble upon it. |
How does one get rid of these warning when using I have been using the config in this starter kit And adding the above mentioned to the config/webpack.common.js doesn't do the trick. There is also the config/webpack.dev.js that uses the cheap-module-source-map option.. I can't find anywhere how you are supposed to exclude files this way.. These warnings are fine but then if I pass it onto another dev they might get worried! |
@JustSayNO I looked up the mentioned starter kit and it would seem they already do such excludes for node_modules in webpack.common.js (which is merged into webpack.dev.js) and webpack.test.js Example from webpack.common.js
You should be able to add one entry in the exclude array like Webpack seems to recommend using the include over the exclude when possible (see Example in https://webpack.github.io/docs/configuration.html#module-loaders). In general the include / exclude works by passing one condition or an array of conditions which in turn can be path references or regular expressions. Hope this helps. |
Yeah I tried adding that line before I made my post.. I'm not sure why its not effecting the output tbh. My loader for that looks like this:
|
Suppresses some warnings from angular-cli@webpack May also fix angular-redux#64.
Hey,
just a minor thing. Might not even be worth mentioning it in the README. When using the source-map-loader to extract source maps without any excludes ng2-redux 2.2.3 displays warnings.
The app still works. To avoid the warnings it can be simply excluded.
Cheers,
Tobi
The text was updated successfully, but these errors were encountered: