Skip to content

fix #118 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2015
Merged

fix #118 #124

merged 3 commits into from
Sep 23, 2015

Conversation

e-cloud
Copy link
Contributor

@e-cloud e-cloud commented Sep 12, 2015

fix #118

  • add umd support and move the source to the src directory
  • take the html fragment out of the js file, and use grunt-angular-templates and grunt-replace plugin to generate the templateCache and insert it into the js file
  • apply ngAnnotate plugin to the build flow

@e-cloud
Copy link
Contributor Author

e-cloud commented Sep 12, 2015

one thing is forgot to be mentioned -- provide an unminified version in the dist directory for the src's one is uncompleted

@ValentinH
Copy link
Member

Thanks for this PR.

ValentinH added a commit that referenced this pull request Sep 23, 2015
Add umd support. Extract template in its own file.
@ValentinH ValentinH merged commit 9bddbec into angular-slider:master Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor request] can I do some refactorization and improvement
2 participants