Skip to content

fix(Typescript Support): Add missing definitions to typescript d.ts file #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

trodi
Copy link
Contributor

@trodi trodi commented Aug 18, 2017

I added all the missing properties to the typescript type definition file. Additionally, I updated the package-lock file due to #555. I can make that change a separate PR or remove entirely if you wish.

@codecov-io
Copy link

Codecov Report

Merging #556 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #556   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         945    945           
=====================================
  Hits          945    945

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7198e...25ae2b0. Read the comment docs.

@ValentinH
Copy link
Member

Lol you were faster than I was to answer your issue! ^^

@ValentinH ValentinH merged commit 5101c1a into angular-slider:master Aug 18, 2017
@trodi trodi deleted the update-typescript-support branch August 18, 2017 17:21
@trodi trodi mentioned this pull request Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants