Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Typescript): typescript support for ticksArray as array of objects #666

Merged
merged 2 commits into from
Mar 9, 2019

Conversation

trodi
Copy link
Contributor

@trodi trodi commented Mar 6, 2019

Updates typescript definition file to support the new use case of ticksArray added in #662

@codecov-io
Copy link

codecov-io commented Mar 6, 2019

Codecov Report

Merging #666 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #666   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines        1004   1004           
=====================================
  Hits         1004   1004

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3499df0...16c4103. Read the comment docs.

@ValentinH ValentinH merged commit 28bf4e7 into angular-slider:master Mar 9, 2019
@ValentinH
Copy link
Member

Do I need to release a new version?

@trodi trodi deleted the typescript-ticksArray branch March 11, 2019 14:35
@trodi
Copy link
Contributor Author

trodi commented Mar 11, 2019

@ValentinH I don't personally need it yet, but a new release will be required for someone to take advantage of the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants