Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.
This repository was archived by the owner on May 29, 2019. It is now read-only.

Dialog: allow merging of css classes between global options and instance options #294

@rewritten

Description

@rewritten

When an application has global styles defined, the natural thing would be to configure some class through the provider, like (sorry for the CoffeeScript code, I can't write plain JS anymore....)

myModule.config ["$dialogProvider", ($dialogProvider) ->
  $dialogProvider.options
    modalClass: "some-global-class"
]

But then an instance of Dialog can't add another class, it must specify the whole list of classes:

$dialog.dialog
  modalClass: "some-global-class specific-class"
.open()

Thus, it's a burden to track everywhere the global dialog class. If one could have something like

$dialog.dialog
  modalAdditionalClass: "specific-class"
.open()

this could be added to the globally configured one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions