Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Collapse broken in 0.13.0 #3676

Closed
hugomenesesp opened this issue May 15, 2015 · 12 comments
Closed

Collapse broken in 0.13.0 #3676

hugomenesesp opened this issue May 15, 2015 · 12 comments

Comments

@hugomenesesp
Copy link

In 0.12.1 'collapse' works well, but in 0.13.0 the transition is lost. The element just hide/shows in a frame.

@rvanbaalen
Copy link
Contributor

Demonstrate in a plunkr please. And since 0.13.0, ngAnimate is a requirement for transitions and animations. Please include ngAnimate and try again.

We know, the docs still lack this information.

Edit;
@NitroInside Any update on this?

@JohnBernardsson
Copy link

@rvanbaalen I was having exactly the same problem. Including ngAnimate fixes it 👍

And yes, it would be very useful to include a heads up for this in the docs... I've been looking around and testing stuff for one an hour before reaching this post 😆 😆

But anyways, thanks a lot for all the hard work!!!!

@hugomenesesp
Copy link
Author

@rvanbaalen I have included "angular-animate" version 1.3.0-rc.4 via Bower since a long time in my project (and just broke with this version of angular-ui-bootstrap)... can I use that module or must be ngAnimate mandatory?

And I think the error is due because I'm using this module via Bower (through the wrapper https://github.com/angular-ui/bootstrap-bower) and it has no other dependencies than Angular, so I suppose that their bower.json must include the dependency. I'm I right?

Thank you so much for the help and hard work!

@rvanbaalen
Copy link
Contributor

@EvilJohnny Sorry for that pal 😉 We too make some mistakes sometimes haha.

@NitroInside It's never recommended to use an Release Candidate version if there's a stable release available instead.

@rvanbaalen rvanbaalen added this to the Backlog milestone May 23, 2015
@hugomenesesp
Copy link
Author

@rvanbaalen totally agree with that, is an inherited project and it's dependencies are being gradually upgraded =)

@TimonVS
Copy link

TimonVS commented May 28, 2015

@NitroInside I created a gist with my solution for ngAnimate 1.4: https://gist.github.com/TimonVS/a40514121fb220495d8c.

@pcnate
Copy link

pcnate commented Jun 3, 2015

I have a similar issue with v0.13.0.

The element is hidden on page load, I set an initial $scope.collapse = false; as the first line in my controller. It just pops into view well after page load with no animation. Animation works after that.

I revert back to 0.12.1 and it functions as intended. Using angular & angular-animate v1.3.15

@wesleycho
Copy link
Contributor

@pcnate can you reproduce this in a Plunker?

@lucienbertin
Copy link

I had problems with this too, could you update the dependencies on the home page

also, the plunker for the collapse does not work due to the missing ngAnimate so that's a bit desorienting

@wesleycho
Copy link
Contributor

I'm confused - is the expectation that there is an initial animation to the uncollapsed state?

@pcnate
Copy link

pcnate commented Jun 11, 2015

0.12.x results

  1. $scope.collapse = false
  2. Item is visible
  3. Animation works by toggling $scope.collapse

0.13.0 results

  1. $scope.collapse = false
  2. Item is hidden
  3. n seconds later element pops into view with no transition
  4. Animation works by toggleing $scope.collapse

I am experiencing this on Chrome 44.0.2403.39

Also related to issue #3801

@wesleycho
Copy link
Contributor

This should currently be fixed on master & 0.13.1.

It should also be noted, ngAnimate is an optional dependency - the animations won't occur without it, which allows users the choice.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants