New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse broken in 0.13.0 #3676

Closed
hugomenesesp opened this Issue May 15, 2015 · 12 comments

Comments

Projects
None yet
7 participants
@hugomenesesp
Copy link

hugomenesesp commented May 15, 2015

In 0.12.1 'collapse' works well, but in 0.13.0 the transition is lost. The element just hide/shows in a frame.

@rvanbaalen

This comment has been minimized.

Copy link
Contributor

rvanbaalen commented May 15, 2015

Demonstrate in a plunkr please. And since 0.13.0, ngAnimate is a requirement for transitions and animations. Please include ngAnimate and try again.

We know, the docs still lack this information.

Edit;
@NitroInside Any update on this?

@JohnBernardsson

This comment has been minimized.

Copy link

JohnBernardsson commented May 22, 2015

@rvanbaalen I was having exactly the same problem. Including ngAnimate fixes it 👍

And yes, it would be very useful to include a heads up for this in the docs... I've been looking around and testing stuff for one an hour before reaching this post 😆 😆

But anyways, thanks a lot for all the hard work!!!!

@hugomenesesp

This comment has been minimized.

Copy link
Author

hugomenesesp commented May 23, 2015

@rvanbaalen I have included "angular-animate" version 1.3.0-rc.4 via Bower since a long time in my project (and just broke with this version of angular-ui-bootstrap)... can I use that module or must be ngAnimate mandatory?

And I think the error is due because I'm using this module via Bower (through the wrapper https://github.com/angular-ui/bootstrap-bower) and it has no other dependencies than Angular, so I suppose that their bower.json must include the dependency. I'm I right?

Thank you so much for the help and hard work!

@rvanbaalen

This comment has been minimized.

Copy link
Contributor

rvanbaalen commented May 23, 2015

@EvilJohnny Sorry for that pal 😉 We too make some mistakes sometimes haha.

@NitroInside It's never recommended to use an Release Candidate version if there's a stable release available instead.

@rvanbaalen rvanbaalen added this to the Backlog milestone May 23, 2015

@hugomenesesp

This comment has been minimized.

Copy link
Author

hugomenesesp commented May 24, 2015

@rvanbaalen totally agree with that, is an inherited project and it's dependencies are being gradually upgraded =)

@TimonVS

This comment has been minimized.

Copy link

TimonVS commented May 28, 2015

@NitroInside I created a gist with my solution for ngAnimate 1.4: https://gist.github.com/TimonVS/a40514121fb220495d8c.

@pcnate

This comment has been minimized.

Copy link

pcnate commented Jun 3, 2015

I have a similar issue with v0.13.0.

The element is hidden on page load, I set an initial $scope.collapse = false; as the first line in my controller. It just pops into view well after page load with no animation. Animation works after that.

I revert back to 0.12.1 and it functions as intended. Using angular & angular-animate v1.3.15

@wesleycho

This comment has been minimized.

Copy link
Member

wesleycho commented Jun 4, 2015

@pcnate can you reproduce this in a Plunker?

@lucienbertin

This comment has been minimized.

Copy link

lucienbertin commented Jun 5, 2015

I had problems with this too, could you update the dependencies on the home page

also, the plunker for the collapse does not work due to the missing ngAnimate so that's a bit desorienting

@wesleycho

This comment has been minimized.

Copy link
Member

wesleycho commented Jun 11, 2015

I'm confused - is the expectation that there is an initial animation to the uncollapsed state?

@pcnate

This comment has been minimized.

Copy link

pcnate commented Jun 11, 2015

0.12.x results

  1. $scope.collapse = false
  2. Item is visible
  3. Animation works by toggling $scope.collapse

0.13.0 results

  1. $scope.collapse = false
  2. Item is hidden
  3. n seconds later element pops into view with no transition
  4. Animation works by toggleing $scope.collapse

I am experiencing this on Chrome 44.0.2403.39

Also related to issue #3801

@wesleycho

This comment has been minimized.

Copy link
Member

wesleycho commented Jul 31, 2015

This should currently be fixed on master & 0.13.1.

It should also be noted, ngAnimate is an optional dependency - the animations won't occur without it, which allows users the choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment