dialog closes on $location.search() change even when reloadOnSearch:false

[lkende]

I noticed that when I have a dialog open and change a param using $location.search() that my dialog closes. (I have reloadOnSearch: false in my $routeProvider for the page in question). Take for example that a user interaction within a dialog sets a query param in the address without firing a route change.

Looking into dialog in angular-bootstrap js, I see relavent code:

 Dialog.prototype._bindEvents = function() {
      ....
      this.$scope.$on('$locationChangeSuccess', this.handleLocationChange);
    };


 this.handleLocationChange = function() {
        self.close();
      };

Would it not make more sense to change this event to?

this.$scope.$on('$routeChangeSuccess', this.handleLocationChange);

This appears to fix it, but hate to make modifications to code supplied by third-parties since upgrades require going back in and remembering to make modifications again. I can understand that if the route were to actually change that the dialog should close. Maybe this could be supplied in opts, or possibly check the config? I'm not sure the possibilities, but wanted to bring this up.

[pkozlowski-opensource]

@lkende $routeChangeSuccess wouldn't be enough since it wouldn't work for people not using routing. Anyway, I've reverted for now the part of the code that watches for the location change in db366a8.

I will look into this location-related issues while dealing with #441

[pursual]

This is still an issue. Changing location.search instantly closes the dropdowns, with no apparent way to override.