Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Fix heavy dependence on the DOM for carousel transition information #4516

Closed
wesleycho opened this issue Oct 3, 2015 · 2 comments
Closed

Comments

@wesleycho
Copy link
Contributor

See discussion in #4325 - this exposes a heavy dependence on the DOM structure, which defies the custom template possibilities.

This needs to be untangled in a clean way to avoid the heavy dependence and part of the limitations of .animation - might need to store all the slides for a carousel in a model using $$multiMap.

@chrisirhc
Copy link
Contributor

The NO_TRANSITION hack was there because there was no way to use $animate.enabled as a getter (the getter was added in Angular 1.4). Now that that's no longer true, we can remove the usage of .data . Now if we're updating the dependency to Angular 1.4, it can instead use $animate.enabled on itself, as $animate.enabled gets inherited by children.

@wesleycho
Copy link
Contributor Author

Thanks for that - that is exactly the info I needed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants