Skip to content
This repository has been archived by the owner. It is now read-only.

Timepicker: DST issue #5485

Closed
joh-klein opened this issue Feb 16, 2016 · 5 comments
Closed

Timepicker: DST issue #5485

joh-klein opened this issue Feb 16, 2016 · 5 comments

Comments

@joh-klein
Copy link

@joh-klein joh-klein commented Feb 16, 2016

On the fall day of DST the time picker can't go forward past 2 AM

http://plnkr.co/edit/f1kiq5J89eOhBLgtstRT?p=preview

@wesleycho
Copy link
Member

@wesleycho wesleycho commented Feb 16, 2016

I'm not seeing this - can you give me the exact steps you are taking to see the issue?

@joh-klein
Copy link
Author

@joh-klein joh-klein commented Feb 17, 2016

Ah, I think this might happen, if the day to switch back from DST in your time zone differs from mine (2016-10-30). Please change $scope.mytime accordingly.

@wesleycho
Copy link
Member

@wesleycho wesleycho commented Mar 1, 2016

Got it, finally was able to reproduce in the Pacific timezone: http://plnkr.co/edit/aJSWySs4N458sERn7yum?p=preview

This is an interesting bug. We likely need to add a check in the increment method in the timepicker & special timezone handling - the decrement one seems to work properly.

Edit: fixing the increment probably will introduce a problem into decrement - this will be tricky.

@sokla
Copy link

@sokla sokla commented May 11, 2016

I really want to know how to use arrowkeys in Timepicker.

@icfantv
Copy link
Member

@icfantv icfantv commented Jul 19, 2016

Closing in favor of #5957 as this will result in a complete rewrite of the widget, addressing all the outstanding issues.

@icfantv icfantv closed this Jul 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.