Timepicker: DST issue #5485

Closed
joh-klein opened this Issue Feb 16, 2016 · 5 comments

Projects

None yet

4 participants

@joh-klein

On the fall day of DST the time picker can't go forward past 2 AM

http://plnkr.co/edit/f1kiq5J89eOhBLgtstRT?p=preview

@wesleycho
Member

I'm not seeing this - can you give me the exact steps you are taking to see the issue?

@joh-klein

Ah, I think this might happen, if the day to switch back from DST in your time zone differs from mine (2016-10-30). Please change $scope.mytime accordingly.

@wesleycho
Member

Got it, finally was able to reproduce in the Pacific timezone: http://plnkr.co/edit/aJSWySs4N458sERn7yum?p=preview

This is an interesting bug. We likely need to add a check in the increment method in the timepicker & special timezone handling - the decrement one seems to work properly.

Edit: fixing the increment probably will introduce a problem into decrement - this will be tricky.

@wesleycho wesleycho added this to the Backlog milestone Mar 5, 2016
@sokla
sokla commented May 11, 2016 edited

I really want to know how to use arrowkeys in Timepicker.

@icfantv
Member
icfantv commented Jul 19, 2016

Closing in favor of #5957 as this will result in a complete rewrite of the widget, addressing all the outstanding issues.

@icfantv icfantv closed this Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment