New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timepicker: DST issue #5485

Closed
joh-klein opened this Issue Feb 16, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@joh-klein

joh-klein commented Feb 16, 2016

On the fall day of DST the time picker can't go forward past 2 AM

http://plnkr.co/edit/f1kiq5J89eOhBLgtstRT?p=preview

@wesleycho

This comment has been minimized.

Member

wesleycho commented Feb 16, 2016

I'm not seeing this - can you give me the exact steps you are taking to see the issue?

@joh-klein

This comment has been minimized.

joh-klein commented Feb 17, 2016

Ah, I think this might happen, if the day to switch back from DST in your time zone differs from mine (2016-10-30). Please change $scope.mytime accordingly.

@wesleycho

This comment has been minimized.

Member

wesleycho commented Mar 1, 2016

Got it, finally was able to reproduce in the Pacific timezone: http://plnkr.co/edit/aJSWySs4N458sERn7yum?p=preview

This is an interesting bug. We likely need to add a check in the increment method in the timepicker & special timezone handling - the decrement one seems to work properly.

Edit: fixing the increment probably will introduce a problem into decrement - this will be tricky.

@sokla

This comment has been minimized.

sokla commented May 11, 2016

I really want to know how to use arrowkeys in Timepicker.

@icfantv

This comment has been minimized.

Member

icfantv commented Jul 19, 2016

Closing in favor of #5957 as this will result in a complete rewrite of the widget, addressing all the outstanding issues.

@icfantv icfantv closed this Jul 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment