Modal dialog throws '$digest already in progress' at close.

[paulbakker]

When closing a dialog everything seems to work, but a "$digest already in progress" error is logged. I'm using the following code (and several variations):

$dialog.messageBox().open('dialogs/deleteDialog.html').then(function(result){
   if(result) {
      //delete stuff
       $route.reload();
   }
});

[pkozlowski-opensource]

@paulbakker Paul would you mind providing a reproduce scenario? You can start with this plunk: http://plnkr.co/edit/8HdUUj?p=preview

I will have a look anyway but having a reproduce plunk would speed up things.

[paulbakker]

I tried reproducing it in the plunk (http://plnkr.co/edit/8HdUUj) but didn't succeed strangely enough. I also tried using the exact same JS references to Angular and angular-bootstrap in my ow codebase (to make sure the versions are correct), but this doesn't change anything. I stripped my code to the bare minimum (still getting the error) and it seems to be the same as on the plunk.

function LearningPathNavigationCtrl($scope, $routeParams, $route, $dialog, Curriculum, LearningPath) {
     $scope.curriculum = Curriculum.get({identifier: $routeParams.curriculum});
     $scope.learningPaths = LearningPath.query({curriculumId: $routeParams.curriculum});

     $scope.deleteLearningPath = function() {
        $dialog.messageBox().open('dialogs/deleteLearningPath.html').then(function(result){

        });
     }
}

<table class="table table-striped">
<tr ng-repeat="path in learningPaths" >
            <td><a href="#/routeplanner/{{path._id}}">{{path.name}}</a></td>
            <td><a href="#/editLearningPath/{{path._id}}" class="btn">Edit</a>
            <div class="btn btn-danger" ng-click="deleteLearningPath()">
                Delete
            </div></td>
        </tr>
        <table>

<div class="modal-header">
    <h1>Delete</h1>
</div>
<div class="modal-body">
    <p>
        Do you want to delete this learning path?
    </p>
</div>
<div class="modal-footer">
    <button ng-click="close(true)" class="btn btn-danger" >Confirm</button>
    <button ng-click="close(false)" class="btn btn" >Cancel</button>
</div>

Sorry for not being very helpful....

[capaj]

I have fixed the error by using safeApply instead of $apply.
On line 198 in angular-ui-bootstrap-dialog.js then:

if(this._fadingEnabled()){
        this.$scope.safeApply();
      }

instead of:

if(this._fadingEnabled()){
        this.$scope.$apply();
      }

When safeapply is defined like this:

$rootScope.safeApply = function(fn) {   //this can get rid of digest phase errors
            var phase = this.$root.$$phase;
            if(phase == '$apply' || phase == '$digest') {
                if(fn && (typeof(fn) === 'function')) {
                    fn();
                }
            } else {
                this.$apply(fn);
            }
        };

Props to Alex Vanston for this: https://coderwall.com/p/ngisma

[petebacondarwin]

@capaj - Sorry but this is a hack not a fix. There are very few cases where it really is not possible to know if you are already in a digest or not and all that I know of are because of dodgy libraries that are not consistent in the way they return their callbacks. If this is a bug in the modal then we should fix it properly. If it is because a 3rd party library is not sure whether it is async or not then it is not a bug in modal.

[petebacondarwin]

So the minimal reproduce scenario is http://plnkr.co/edit/iMxK9H?p=preview
It is caused when dialog.close is called and the modal fade is in use.

[petebacondarwin]

Since $transition already triggers a $digest in order to resolve its promise, you must not try to do so too in the then function. So the lines: https://github.com/angular-ui/bootstrap/blob/master/src/dialog/dialog.js#L198-L200 should be removed. They are only called inside a $digest already.

[capaj]

Thx for the clarification @petebacondarwin. Will try to delete it instead of hacking it with safeApply.

[typesafe]

This $digest call is a leftover from before using the $transition service. Missed it because it didn't break anything, it just fails and logs a message. Definitely a bug in $dialog.

[pkozlowski-opensource]

@petebacondarwin great job pin-pointing this one! @typesafe, are you going to open a PR with a fix? Or do you want me to fix this one?