ng-model on datepicker does not work

[garethdjames]

Using the ng-model attribute on the datepicker directive instead of the surrounding tag causes the datepicker to not bind to the model

I have created a plunkr where the the first datepicker has the ng-model attribute on the datepicker and the second where it has it on the surrounding div

http://plnkr.co/edit/EFYBUuDt23U3wHvsD2rG

Note that this issue does not occur in version 0.4.0

[garethdjames]

The issue relates to the fact the the datepicker directive uses the ngModelController but has an isolated scope to support the dateDisabled attribute, which means you can only set the ngModel on the parent element and not on the datepicker element

[bekos]

Hello @garethdjames and thx for your time.

Indeed, using ngModleController instead of two-way data binding created this problem.
Removing isolated scope from a reusable module that creates scope variables, replaces template etc I believe it's not the best thing to do.

As a workaround you can use : ng-model="$parent.dt" and will behave exact like the previous version.
I hope this helps.

[garethdjames]

For now I have added the ngModel to a parent div.

I attempted a fix by removing the isolated scope and using the $attrs value for isDisabled.

This worked for my test case but spectacularly killed the other date picker test cases.

If I get time later I will have a look at how we can remove the isolated scope

Gareth James

gareth.james@intilery.com
CEO Intilery.com
0844 802 4581
07010 071 432
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Wednesday, 7 August 2013 at 18:59, Tasos Bekos wrote:

Hello @garethdjames (https://github.com/garethdjames) and thx for your time.
Indeed, using ngModleController instead of two-way data binding created this problem.
Removing isolated scope from a reusable module that creates scope variables, replaces template etc I believe it's not the best thing to do.
As a workaround you can use : ng-model="$parent.dt" and will behave exact like the previous version.
I hope this helps.

—
Reply to this email directly or view it on GitHub (#784 (comment)).

[bekos]

I have seen your commit. I don't think removing isolated scope it's a viable option.
As I said before, you can try this: http://plnkr.co/edit/O77xuF8ZsUznViWPI29A?p=preview

[garethdjames]

I agree

I have cancelled the pull request

Gareth James

gareth.james@intilery.com
CEO Intilery.com
0844 802 4581
07010 071 432
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Wednesday, 7 August 2013 at 19:09, Tasos Bekos wrote:

I have seen your commit. I don't think removing isolated scope it's a viable option.
As I said before, you can try this: http://plnkr.co/edit/O77xuF8ZsUznViWPI29A?p=preview

—
Reply to this email directly or view it on GitHub (#784 (comment)).

[bekos]

I suppose we can close it then :-)

[pawanMindyourfleet]

I am using bootstrap timepicker in my code and setting value on page load using ng-model

And loading some html on runtime. Its working fine for me when i set value on page

But when i try to update the value in ng-model it will not reflecting on view side but value is updated in ng-model

Can you help in this.

[ElanHasson]

It seems this issue has been resolved, i've updated the plunker from @garethdjames.

http://plnkr.co/edit/2hLMd4KLbAMWxp2EtHXI

[roshani4]

in a span class ng-model working or not .