This repository was archived by the owner on May 25, 2019. It is now read-only.
"fix" PhantomJS test failures, depend on codemirror >3 #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47
codemirror/codemirror5#2409
Since the maintainer of CodeMirror doesn't want to add bytes his javascript to get test that work in real browsers to pass to work in PhantomJS, we should do what he does and skip the failing tests as well.
I took his suggestion, and implemented the same solution he uses in his code.
I also changed the bower.json dependency for codemirror from "^3" to ">3".