CellClass doesn't change on cellEditing.

[roedit]

Hi.
I found a new issue.
cellClass: function(grid, row, col, rowRenderIndex, colRenderIndex) {
if (grid.getCellValue(row,col) === 'Velity') {
return 'blue';
}
}
I'm editing the grid and change the random cell value to 'Velity', And the grid does not apply the class on the cell.
Also I'm updating the cellClass after editing and nothing happens.
gridApi.edit.on.afterCellEdit($scope,function(rowEntity, colDef, newValue, oldValue){
colDef.cellClass = 'orange';
$scope.$apply();
});
Tried also with a function instead of the 'orange' string . And still nothing.
Also i tried to reset the grid after it.
gridApi.core.refresh();

Nothing seems to be working , only rebuilding the grid.
Could you please help me with an advice, or tell me if i'm wrong ??
Thank you.

[PaulL1]

Any change of providing a plunker for this? That would make it easier to diagnose.

[roedit]

Yes , sure !
Here is a plunker : http://plnkr.co/edit/OKdG9h4QxUevrp94wW0p?p=preview

The only implementation that worked for me was saving the data object with the new values, each time i'm changing a value , then refreshing the page .
Thanks.

[PaulL1]

OK, thanks for this. It looks to me like we set the colouring in code (i.e. it doesn't use ng-class), but that there is actually an ng-class on each cell that relates to rowHeader.

I think from discussions with @c0bra that our preference is to not use ng-class, as that gets validated on every scroll event for every cell, so probably the right answer is to change both of them, but also to have an explicit trigger to recalculate when a cell is changed.

[PaulL1]

This one is perhaps another example of #1819, which could benefit from some standard patterns.

[PaulL1]

Refer pull request #1842 , which I think will resolve this.

[PaulL1]

I've merged and it's updated through to ui-grid.info. I've checked your plunker, and it now looks to be updating the cell class when you edit a cell to Velity.

[roedit]

I've checked and it seems to be working.
Thanks.

[RafaDom]

Thanks a lot PauL1 !!
We've been waiting on this .
I just decided to Post this problem. And look, there's already a fix for this 👍 :)