expandable grid subgrid has no access to external scopes

[idot]

The topmost grid has access to external scope so I can call the delete method on check/uncheck.
The subgrid has no access to the external scope so I cant edit in the subgrid.

http://plnkr.co/edit/EY0RHuHx1oL2ZzHaRjkd?p=info

[rntorm]

How does the scopes exactly work in ui-grid? The parent row of expandable row can obviously access controller scope with getExternalScopes() function. Now the expandable row does not have a scope itself, since scope is set to false in directive. Thus it should inherit getExternalScope() also but this does not seem to work @PaulL1

[PaulL1]

I have to say I don't know. But I know there was a commit went through recently that fixed external scopes in headers and footers, so taking a look at that would probably give a good hint as to what's going on.

[PaulL1]

@jpuri: is this something you would look at?

[jpuri]

Yes @PaulL1 I will look at this.

[jpuri]

Hi @idot ,

The expanded grid template is actually not compiled in the scope of controller but rather in scope of a row. Thus to be available for 'external-scopes' the value should be present in scope of row. This using 'external-scopes' as its right now for expanded rows looks complex.

What I can rather do is add a grid option 'expandedRowScope' and make it available to subgrid.
@PaulL1 , what do you suggest.

[jpuri]

Hi All,
As I mentioned the method 'getExternalScopes()' is available in subgrid scope but controller scope objects (like 'myViewModel' in above plunker) are not available in subgrid scope. Subgrid is created in row scope.
If required I can add a gridoption for expandable grid where you can mention values to be made available in subgrid scope.

Please suggest.

[rntorm]

This would work just fine ! @jpuri

[idot]

What I do now after advice on chat is something like:

           var result = {};
           result.subGridOptions = {
              data : filesToRows(files),
              columnDefs : [
                   { name :'flowcell', field: 'run.flowcell', width: 100 },
                   { name: 'lane', field: 'run.lane', width: 50 },
                   ….
                   { name: 'check', cellTemplate: optionCell('row.entity.resultCheck', 'NA', '{{row.entity.resultCheck.result}}' ), width: 50 }
              ],
              externalScope : $scope.myViewModel
           };

This works with the current ui-grid and is not bad.

On 12 Nov 2014, at 11:59, Jyoti Puri notifications@github.com wrote:

Hi All,
As I mentioned the method 'getExternalScopes()' is available in subgrid scope but controller scope objects (like 'myViewModel' in above plunker) are not available in subgrid scope. Subgrid is created in row scope.
If required I can add a gridoption for expandable grid where you can mention values to be made available in subgrid scope.

Please suggest.

—
Reply to this email directly or view it on GitHub.

[jpuri]

Cool....
Hey @PaulL1/ @rntorm , I think code change should be done for this only if this is a frequent use case,please suggest.

[rntorm]

I do not know how frequent this case is, however the case @idot refers to, is only used when the expandableRow is a new ng-grid. In many cases the expandable row is just an html template that needs to access externalScope. So adding external scope specially for expandableRow will work in more cases! @jpuri