Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4.0.11 Performance issue with ui-grid-auto-resize #6499

Closed
falsyvalues opened this issue Dec 5, 2017 · 0 comments
Closed

v4.0.11 Performance issue with ui-grid-auto-resize #6499

falsyvalues opened this issue Dec 5, 2017 · 0 comments

Comments

@falsyvalues
Copy link
Contributor

Since v4.0.11 uiGridAutoResize use $scope.$watch and its causing repetitive reflow cycles on browser side (clientWidth) in each angular digest cycle. Regression
Regression was introduced in #6470

ui-grid-performance-issue
@falsyvalues falsyvalues mentioned this issue Dec 6, 2017
Merged
falsyvalues added a commit to falsyvalues/ui-grid that referenced this issue Feb 2, 2018
@falsyvalues
fix(uiGridAutoResize): Asking for grid $elm sizing in a digest loop a…
0675f6f 
…lways triggers `refresh`, not conditionally as designed.

We allow `elementWidth` and `elementHeight` call only once per 200ms to prevent from perf degradation.

Fixes angular-ui#6561 angular-ui#6499.
@falsyvalues falsyvalues mentioned this issue Feb 2, 2018
Merged
mportuga pushed a commit that referenced this issue Feb 3, 2018
@falsyvalues @mportuga
fix(uiGridAutoResize): Asking for grid $elm sizing in a digest loop a…
835153c 
…lways triggers `refresh`, not conditionally as designed.

We allow `elementWidth` and `elementHeight` call only once per 200ms to prevent from perf degradation.

Fixes #6561 #6499.
@mportuga mportuga closed this as completed Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@falsyvalues @mportuga