Skip to content

apply extraStyle property to give possibility to change style of dedi… #3928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2016

Conversation

MaksimSimkin
Copy link
Contributor

Hi
I need a possibility for example to arrange two filters in the column in one row, not below each other as in tutorial.
Now i am doing it, overriding style ui-grid-filter-container but it applies than for all columns.
The change i made, adding extra property for a column definition will loose this problem and made grid more variable.

Review on Reviewable

@JLLeitschuh
Copy link
Contributor

I see no problem adding this.

@MaksimSimkin
Copy link
Contributor Author

Added code to fix issue 3985
#3985

It's a workaround, but it solves a problem for ie9.

@JLLeitschuh
Copy link
Contributor

Do these need to be rebased before we can merge them in @c0bra?

@mportuga
Copy link
Member

@MaksimSimkin Can you please resolve the merge conflicts?

Conflicts:
	src/js/core/factories/GridColumn.js
	src/templates/ui-grid/ui-grid-filter.html
@MaksimSimkin
Copy link
Contributor Author

@mportuga conflicts are resolved.

@JLLeitschuh
Copy link
Contributor

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants