Skip to content

Conversation

Namek
Copy link

@Namek Namek commented Sep 9, 2015

I have rebased+squashed PR #3201 of @yccteam.

Added "expandedRowHeight" property to the expanded row.
If it is not defined, the grid's default is used.
Changed the template files to use the "expandedRowHeight" instead of the
grid's default.

Added "rowExpandedBeforeStateChanged" event to "expandable" feature

Can now hook to the event before the change. One scenario this can be
helpful is to dynamically change the expandedRowHeight
@Namek Namek force-pushed the expandable_row_height---author-yccteam branch from 9a3c4e0 to 9e2df5f Compare September 9, 2015 09:36
@Namek
Copy link
Author

Namek commented Sep 9, 2015

I have removed event part of commit from expandable.js because it didn't pass tests:

toggleRowExpansion: function (rowEntity) {
   event.stopPropagation();   // <-- these two lines
   event.preventDefault();    //

swalters added a commit that referenced this pull request Sep 9, 2015
@swalters swalters merged commit 858b4af into angular-ui:master Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants