Update Grid.js modifyRows documentation to match function code #4456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature Current `modifyRows` documentation does not indicate the need to pass the newRawData. Also doesn't explain purpose or use of function (e.g. to immediately select rows after load without $timeout/$interval or to persist selection after data load). Thought I would update this after reading: #2267
swalters
added a commit
that referenced
this pull request
Oct 1, 2015
Update Grid.js modifyRows documentation to match function code
frantisekjandos
pushed a commit
to focscz/ui-grid
that referenced
this pull request
Oct 7, 2015
Update Grid.js modifyRows documentation to match function code modified: CHANGELOG.md modified: bower.json modified: misc/tutorial/102_sorting.ngdoc modified: misc/tutorial/103_filtering.ngdoc modified: misc/tutorial/121_grid_menu.ngdoc modified: package.json modified: src/features/selection/js/selection.js modified: src/js/core/directives/ui-grid.js modified: src/js/core/factories/Grid.js modified: src/js/core/factories/GridColumn.js modified: src/js/core/services/rowSorter.js modified: src/templates/ui-grid/uiGridHeaderCell.html modified: test/e2e/gridTestUtils.spec.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
modifyRowsdocumentation does not indicate the need to passnewRawDataparameter. Also doesn't explain purpose or use of function (e.g. to immediately select rows after load without $timeout/$interval or to persist selection after data load).Thought I would update this after reading: #2267