4687 grid column leak #4704
Merged
4687 grid column leak #4704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent the grid column's hideColumn method being overridden each time a GridColumn is constructed
Prevent the grid column's unsort method being overriden each time a GridColumn is constructed
| * @methodOf ui.grid.class:GridColumn | ||
| * @description Hides the column by setting colDef.visible = false | ||
| */ | ||
| GridColumn.prototype.hideColumn = function() { |
There was a problem hiding this comment.
I couldn't see anywhere in the codebase where this method is actually called...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes another leak found in issue #4687 (leak begins when switching between two pages with grids present).
Caused by GridColumn's hideColumn + unsort methods overriden prototype of all constructed GridColumns each time a GridColumn is constructed. Each of these methods kept a reference to grid via the self property in the closure scope.