Skip to content

- Fixed modifyRows when using enableRowHashing option #4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

- Fixed modifyRows when using enableRowHashing option #4818

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2791ac4
- Fixed modifyRows when using enableRowHashing option
idangozlan Dec 7, 2015
594bccc
Merge branch 'master' into fix-modifyRows-idangozlan
idangozlan Dec 9, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/js/core/factories/Grid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,11 @@ angular.module('ui.grid')
var newRow;
if ( self.options.enableRowHashing ){
// if hashing is enabled, then this row will be in the hash if we already know about it
newRow = oldRowHash.get( newEntity );
var oldRow = oldRowHash.get( newEntity );
if ( oldRow ) {
newRow = oldRow;
newRow.entity = newEntity;
}
} else {
// otherwise, manually search the oldRows to see if we can find this row
newRow = self.getRow(newEntity, oldRows);
Expand Down