Add selection PublicApi method to expose selected count #4925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method would help in implementations that show the number of selected items in a different way that the bottom info-bar.
Previously, the only ways to get the number of items are selected are less than ideal:
getSelectedGridRows().length
on the API - this is slow becausegetSelectedGridRows()
calls a filter on the entire dataset - which would be a performance drag if called every$digest
cycle. One can avoid calling it on every cycle by binding a function that calls it to bothrowSelectionChanged
, androwSelectionChangedBatch
, but the resulting code is way less clear than simplyapi.selection. getSelectedCount()
Or 2) Render and hide the info bar, and try to parse its number. This should be avoided, as it's a hacky solution.
Since the number is already being held (and used internally), providing the number is trivial; so it seems like a good candidate for the API.