fix(core): Fix watcher handler columnDefs assignment #4963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want to use fastWatch:true for data and columnDefs then the $watch handler needs to work with both fastWatch:true and false (or undefined). When mapping the incoming columnDefs with the internal columnDefs, always use what is on $scope instead of what the watcher is watching because the watcher is watching different things in the two different cases. angular-ui#3755
swalters
changed the title
swalters
added a commit
that referenced
this pull request
Jan 22, 2016
fix(core): Fix watcher handler columnDefs assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to use fastWatch:true for data and columnDefs then the $watch handler needs to work with both fastWatch:true and false (or undefined). When mapping the incoming columnDefs with the internal columnDefs, always use what is on $scope instead of what the watcher is watching because the watcher is watching different things in the two different cases.
#3755