Skip to content

fix(core): Fix watcher handler columnDefs assignment #4963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2016

Conversation

mattslocum
Copy link
Contributor

If you want to use fastWatch:true for data and columnDefs then the $watch handler needs to work with both fastWatch:true and false (or undefined). When mapping the incoming columnDefs with the internal columnDefs, always use what is on $scope instead of what the watcher is watching because the watcher is watching different things in the two different cases.

#3755

If you want to use fastWatch:true for data and columnDefs then the $watch handler needs to work with both fastWatch:true and false (or undefined). When mapping the incoming columnDefs with the internal columnDefs, always use what is on $scope instead of what the watcher is watching because the watcher is watching different things in the two different cases.

angular-ui#3755
@swalters swalters changed the title FastWatch :: Fix watcher handler columnDefs assignment fix(core): Fix watcher handler columnDefs assignment Jan 19, 2016
swalters added a commit that referenced this pull request Jan 22, 2016
fix(core): Fix watcher handler columnDefs assignment
@swalters swalters merged commit bbda255 into angular-ui:master Jan 22, 2016
@mattslocum mattslocum deleted the patch-1 branch January 22, 2016 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants