Skip to content

fix(rtl): Fixed pagination button direction in RTL #5013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2016
Merged

fix(rtl): Fixed pagination button direction in RTL #5013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions src/features/pagination/less/pagination.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
@import (reference) "../../../less/bootstrap/bootstrap";

.ui-grid-pager-panel {
position: absolute;
left: 0;
bottom: 0;
width: 100%;
padding-top: 3px;
padding-bottom: 3px;
box-sizing: content-box;
position: absolute;
left: 0;
bottom: 0;
width: 100%;
padding-top: 3px;
padding-bottom: 3px;
box-sizing: content-box;
}

.ui-grid-pager-container {
Expand Down Expand Up @@ -53,6 +53,14 @@
margin-left: -3px;
}

.first-bar-rtl {
width: 10px;
border-left: 2px solid #4d4d4d;
margin-top: -6px;
height: 12px;
margin-right: -7px;
}

.first-triangle {
width: 0;
height: 0;
Expand Down Expand Up @@ -86,6 +94,16 @@
height: 12px;
margin-left: 1px;
}

.last-bar-rtl {
width: 10px;
border-left: 2px solid #4d4d4d;
margin-top: -6px;
height: 12px;
margin-right: -11px;
}


}

.ui-grid-pager-row-count-picker {
Expand Down
12 changes: 6 additions & 6 deletions src/features/pagination/templates/pagination.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
ng-click="pageFirstPageClick()"
ng-disabled="cantPageBackward()">
<div
class="first-triangle">
ng-class="grid.isRTL() ? 'last-triangle' : 'first-triangle'">
<div
class="first-bar">
ng-class="grid.isRTL() ? 'last-bar-rtl' : 'first-bar'">
</div>
</div>
</button>
Expand All @@ -32,7 +32,7 @@
ui-grid-one-bind-aria-label="aria.pageBack"
ng-click="pagePreviousPageClick()"
ng-disabled="cantPageBackward()">
<div class="first-triangle prev-triangle"></div>
<div ng-class="grid.isRTL() ? 'last-triangle prev-triangle' : 'first-triangle prev-triangle'"></div>
</button>
<input
type="number"
Expand Down Expand Up @@ -60,7 +60,7 @@
ui-grid-one-bind-aria-label="aria.pageForward"
ng-click="pageNextPageClick()"
ng-disabled="cantPageForward()">
<div class="last-triangle next-triangle"></div>
<div ng-class="grid.isRTL() ? 'first-triangle next-triangle' : 'last-triangle next-triangle'"></div>
</button>
<button
type="button"
Expand All @@ -70,8 +70,8 @@
ui-grid-one-bind-aria-label="aria.pageToLast"
ng-click="pageLastPageClick()"
ng-disabled="cantPageToLast()">
<div class="last-triangle">
<div class="last-bar">
<div ng-class="grid.isRTL() ? 'first-triangle' : 'last-triangle'">
<div ng-class="grid.isRTL() ? 'first-bar-rtl' : 'last-bar'">
</div>
</div>
</button>
Expand Down