Apply column visibility properly #5304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix removes an unneeded additional function when setting column visibility. Since both functions were of the same priority level, it was possible that the visibility that was passed in would be overwritten with the default value of true under certain circumstances. There was really no need for two functions, as this default behavior can be accomplished in one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix removes an unneeded additional function when setting
column visibility. Since both functions were of the same
priority level, it was possible that the visibility that
was passed in would be overwritten with the default value of
true under certain circumstances. There was really no need
for two functions, as this default behavior can be accomplished
in one. This fixes the following issue: #5303