Skip to content

fix(cellnav): when grid has only one focusable column, should navigat… #5744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sglogowski
Copy link
Contributor

When only one columns is focusable function 'getRowColRight' should return 'GridRowColumn' from next row and function 'getRowColLeft' should return 'GridRowColumn' from previous row. Similar behave occurred now(only when grid has more than one focusable columns) from first and last focusable columns in row.

@dlgski
Copy link
Contributor

dlgski commented Oct 17, 2016

can you provide a plunker?

@sglogowski
Copy link
Contributor Author

Yes, sure : )

Here are two examples, first has grid with two focusable columns:

https://embed.plnkr.co/gFOVEDQxlcARf1n7Wc5V/

Second has grid with only one focusable column:

https://embed.plnkr.co/l1LPBdAz4vMnbmdwdhJv/

Try on both grids move between cells, like you can see on first grid after last cell in row focus move to next cell in next row, in second example focus is locked. The behave with 'Tab' key(and 'Shift' + 'Tab') is even worst, the focus in second example move out of grid(where in first example moves over cells and rows)

I'm trying create example with my fix, but i can't attach that large file to plunker

I hope i described this in clear way, if you have more question about this, please feel free to ask.

@dlgski dlgski merged commit 9849b83 into angular-ui:master Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants