Fixes issue #5799, eventOrigin not getting passed to begin edit when edit mode is triggered by cellNav #5797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where when all features are applied to grid and enableCellEditOnFocus is set to true the edit event would not pass the event to the beginEdit method causing issues with custom editors that rely on the type of event that triggered the cell into edit mode.
|
Hi @jedancona can you reference the issue as part of your PR description? plunkers are helpful as well |
|
The plunker below demonstrates the issue that this PR fixes. Take a look at the comments in the ui-custom-editor.js file. |
jedancona
changed the title
jedancona
changed the title
mportuga
approved these changes
Nov 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where when ALL FEATURES are applied to grid and
enableCellEditOnFocus is set to true the edit event would not pass the
event to the beginEdit method causing issues with custom editors that
rely on the type of event that triggered the cell into edit mode.