fix(6017): Fixes ui-grid-viewport scroll issue in chrome v56 #6125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome v56 introduced a new feature called "scroll anchoring" which causes the scroll position to update if element content above the current scroll position has changed. Since ui-grid-viewport updates the margin of the first line whenever a user is scrolling, scroll anchoring will cause it to get into a scroll loop and scroll indefinitely (i.e. scroll to the end of the grid). Credit to @Joel-Kornbluh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome v56 introduced a new feature called "scroll anchoring" which causes the scroll position to
update if element content above the current scroll position has changed. Since ui-grid-viewport updates the margin of the first line whenever a user is scrolling, scroll
anchoring will cause it to get into a scroll loop and scroll indefinitely (i.e. scroll to the end of
the grid). Credit to @Joel-Kornbluh