Skip to content

fix: 6388 RowSorter doesn't sort numberStr in scientific notation correctly #7180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2021
Merged

fix: 6388 RowSorter doesn't sort numberStr in scientific notation correctly #7180

merged 4 commits into from
Dec 6, 2021

Conversation

prx-lmo
Copy link
Contributor

@prx-lmo prx-lmo commented Oct 1, 2021 •
edited
Loading

@prx-lmo
[hotfix/6388]
839a9b6 
  - scientific notation now also gets parsed to number on sort number string, including e, Infinity and -Infinity
@commit-lint
Copy link

commit-lint bot commented Oct 1, 2021

Contributors

prx-lmo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

prx-lmo added 3 commits October 1, 2021 08:28
@prx-lmo
Merge branch 'master' into hotfix/6388
bb68cab 
# Conflicts:
#	packages/core/src/js/services/rowSorter.js
@prx-lmo
[hotfix/6388]
1c4eeea 
 - fixed code style error
@prx-lmo
[hotfix/6388]
7767183 
 - style fix
@mportuga mportuga self-requested a review December 6, 2021 18:43
@mportuga mportuga merged commit 9031069 into angular-ui:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mportuga mportuga mportuga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RowSorter doesn't sort numberStr in scientific notation correctly
2 participants
@prx-lmo @mportuga