This repository was archived by the owner on Sep 20, 2019. It is now read-only.
Addition of on delete actions for overlays #308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(FYI: I am not really an angular or JavaScript developer, having not done any proper front end development in a long while so apologies if this doesn't fit the code style etc.)
This is partially addressing the TODO present in the layers directive:
We noticed on one of our applications that there was a memory leak to do with a heatmap overlay that refreshed every 10 seconds. It seemed like Chrome was keeping a reference to the many points being fed into the layer, adding in the ability to clean up the heatmap layer upon refresh seemed to eliminate this issue.
I might be able to come up with an example piece of code showing the issue at some point but basically this PR adds the ability to add an action that should be executed on the old layer before it is removed from the leaflet overlays array.
Example configuration (using heatmap support provided by ui-leaflet-layers):