-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uiOnParamsChanged not fired if used with componentProvider #3707
uiOnParamsChanged not fired if used with componentProvider #3707
Comments
The reason for the issue seems to be lying in this check: ui-router/src/directives/viewDirective.ts Line 434 in 5fb93d0
|
@christopherthielen sorry to bother you, but are there any news regarding this issue? |
@Maximaximum thanks for the nice bug report. will be fixed in the next release. |
Looking forward to the new release! Thanks a lot for your work! :) |
@christopherthielen could you please give a hint on when a new version is going to be released? |
This is a (check one box):
My version of UI-Router is: (type version)
1.0.5
Bug Report
Current Behavior:
Clicking the "1" and "2" links inside the stackblitz app does not change the displayed param value because component's
uiOnParamsChanged
method is never called. However, if you comment away the lines 22-24 and uncomment line 21 (i.e., usecomponent
instead ofcomponentProvider
in the state definition), everything works just as expected.Expected Behavior:
Clicking the "1" and "2" links inside the stackblitz app should change the displayed param value to, respectively, "1" or "2", because the component's
uiOnParamsChanged
is called whenever a state param value changes.Link to Plunker or stackblitz that reproduces the issue:
https://stackblitz.com/edit/ui-router-angularjs-budr1v
The text was updated successfully, but these errors were encountered: