ui-router and android 2.2 browser

[heinij]

ui-sref links do not work in the Android 2.2 browser. The problem seems to be in
the parseStateRef function in angular-ui-router.js

function parseStateRef(ref) {
var parsed = ref.match(/^([^(]+?)\s_(((._)))?$/);
if (!parsed || parsed.length !== 4) throw new Error("Invalid state ref '" + ref + "'");
return { state: parsed[1], paramExpr: parsed[3] || null };
}

parsed always returns null

[nateabele]

Okay, does it have a broken regex engine? Can you show me some of the state refs that return null?

[heinij]

It returns null for any string

On Thu, Oct 31, 2013 at 8:07 PM, Nate Abele notifications@github.comwrote:

Okay, does it have a broken regex engine? Can you show me some of the
state refs that return null?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/531#issuecomment-27522865
.

Vinarliga

Heini Justinussen
SP/F Teldni
Tlf: +298 22 69 13

[ltullman]

I just encountered this as well. For now I have put in an Android 2 check to bypass the regex match and simply return the state object but I'm sure that's not the optimal solution.

[nateabele]

Okay, is it something particular to this regex, or is the regex engine on Android just totally broken? More details on this would be great.

[ltullman]

Sorry Nate, I'm not sure what the answer is. It shows up if you run a UI-router sample using a phonegap or trigger.io native/hybrid app running on android emulator 2.2. It's possible it would also be broken in the default android 2.2 web browser as well for testing purposes. If I get time later this month I will revisit but for now I've had to put in a workaround due to near term deadlines.

[flinn]

I'm seeing this issue when deploying to android device with version 4.2.2 as well :)

Is the quick-fix pushed somewhere that I could use for now or is the better workaround to just not use ui-sref links in the phonegap app for now? Thanks!

[ltullman]

Not pushed anywhere. I haven't seen it on Android 4.x at all so far
either. Here's my hacked version of parseStateRef()

---

function parseStateRef(ref) {
var parsed = ref.match(/^([^(]+?)\s_(((._)))?$/);

// If we're on a droid 2.x device and the parsed state is null, just

return the ref as the state.
var userAgent = navigator.userAgent.toLowerCase();
var isDroid2 = userAgent.indexOf("; android 2") > -1;
if (parsed == null && ref != null && isDroid2 ) {
return { state: ref, paramExpr: null };
}

if (!parsed || parsed.length !== 4) throw new Error("Invalid state ref

'" + ref + "'");
return { state: parsed[1], paramExpr: parsed[3] || null };
}

On Mon, Nov 18, 2013 at 11:04 AM, flinn notifications@github.com wrote:

I'm seeing this issue when deploying to android device with version 4.2.2
as well :)

Is the quick-fix pushed somewhere that I could use for now or is the
better workaround to just not use ui-sref links in the phonegap app for
now? Thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/531#issuecomment-28722030
.

[sebnilsson]

I've noticed the same problem on an emulator of an iPhone 4 with iOS 4. It seems the regex doesn't match correctly.

@ltullman's hack works (used as a fallback, instead of looking for Android), but I'd rather not mess with the library's source-code.

[nateabele]

@ltullman Based on your fix, it looks like this does not affect values in the form of ui-sref="state({ param: value })"... is that correct?

[sebnilsson]

Trying it out on a iPhone-simulator with iOS 4, I can confirm that ui-sref="state()" works, while an sref without the parenthesis gives the Invalid state ref-error.

[nateabele]

@sebnilsson Thanks for that info. I'll see if I can replicate it and figure out a permanent fix.

[sebastianzillessen]

Is this problem already fixed?

[OscarBarrett]

This problem still affects iOS 4, though I'm not sure if there is any point supporting a mobile OS that is now 5 years old.

[eddiemonge]

Yeah IOS 4 support doesn't seem like its needed.

https://gist.github.com/eddiemonge/f6a58169c2846731a1eb